Fix dev bulk-delete button gate + reposition inside campaigns

Gate was process.env.NODE_ENV === 'development' — unsafe default. react-scripts
inlines NODE_ENV=development when unset, so prod deploys forgetting the env var
exposed the delete-all button. Switched to explicit opt-in REACT_APP_DEV_TOOLS=1.

process.env.REACT_APP_DEV_TOOLS as static literal gets inlined by DefinePlugin at
webpack build time — runtime mutations in tests had no effect, and dev-start
without the env produced bundles with the branch dead-stripped. Extracted gate
to src/config/devTools.js using dynamic key access
(process.env['REACT_APP_' + 'DEV_TOOLS']) so DefinePlugin cannot inline it; the
value is read at runtime. dev-start.sh now exports REACT_APP_DEV_TOOLS=1.

Button had also drifted outside the campaigns collapse block to the page bottom;
moved it back inside the campaigns section after the grid.

Tests cover both paths: gate logic (unset/0/arbitrary/1) in BulkDelete.gate.test.js,
prod safety render (button absent when unset) in BulkDelete.render-hidden.test.js,
dev feature render (button present when DEV_TOOLS=1) in BulkDelete.render-shown.test.js.

This commit is contained in:

david raistrick

2026-07-08 11:46:56 -04:00

parent 6f11edab94

commit 4a92c667c5

7 changed files with 139 additions and 12 deletions

									
										scripts/dev-start.sh
									
		+1
		
												View File
												
				@@ -28,6 +28,7 @@ fi

				# frontend: server storage, :3999

				if ! lsof -ti :3999 >/dev/null 2>&1; then

				  echo "starting frontend :3999..."

				  NODE_ENV=development REACT_APP_DEV_TOOLS=1 \

				  REACT_APP_STORAGE=server \

				  REACT_APP_BACKEND_URL=http://127.0.0.1:4001 \

				  REACT_APP_BACKEND_REALTIME_URL=ws://127.0.0.1:4001/ws \