diff --git a/TODO.md b/TODO.md index 7be198a..ec7f405 100644 --- a/TODO.md +++ b/TODO.md @@ -4,17 +4,9 @@ Backlog of bugs + long-term items. Milestones live in REWORK_PLAN.md. ## Open -### BUG: add participants duplication alert disappears fast -- Duplicate-add throws alert but toast vanishes before user reads. -- Fix: extend toast duration OR require manual dismiss. - -### FEAT: filter already-added from add-participant dropdown -- Character list dropdown shows characters already in encounter. -- Filter them out (or disable with strike-through). - ### FEAT-2: structured combat logs (parseable) - Goal: logs in storage carry enough state to run skip/rotation analysis - on ANY historic round — not just replay stdout. + on ANY historic round --- not just replay stdout. - Current: `{timestamp, message, encounterName, undo}`. Parser guesses roster from message strings. Brittle. - Upgrade: structured fields at turn-state mutation log sites in App.js @@ -78,6 +70,16 @@ Backlog of bugs + long-term items. Milestones live in REWORK_PLAN.md. - Initiative field at add-char, add-monster, edit participant. - Inline edit wired. Tie-break = drag order. +### UI feedback: toast + info modal (DONE) +- All 23 native alert() replaced. ToastStack (6s auto-dismiss + manual X) + for transient failures. InfoModal (persistent OK) for validations. + React context provider wraps all 3 App branches. +- Fixed: native alert vanished instantly on browser focus loss. + +### Filter dup chars from add-participant dropdown (DONE) +- Character dropdown excludes chars already in encounter. Prevents + dup-add at source. No more dup alert path needed. + ### Test timeouts (DONE) - jest.setTimeout(10000) in setupTests.js (CRA blocks config-level timeout). @@ -91,57 +93,57 @@ Backlog of bugs + long-term items. Milestones live in REWORK_PLAN.md. - FIXED (addParticipant throws on dup id). ### BUG-4: hide-player-HP breaks display view -- FIXED — mock honors setDoc{merge}, all 5 activeDisplay sites use merge. +- FIXED --- mock honors setDoc{merge}, all 5 activeDisplay sites use merge. ### BUG-5: mid-round addParticipant/revive corrupts rotation -- FIXED — slot-array + DRY advance core nextActiveAfter. +- FIXED --- slot-array + DRY advance core nextActiveAfter. ### BUG-6: reorderParticipants doesn't update turnOrderIds - FIXED structurally by 1-list model. ### BUG-7: reorderParticipants not logged -- FIXED — returns log:{message, undo}. Handler calls logAction. deathSave, +- FIXED --- returns log:{message, undo}. Handler calls logAction. deathSave, addParticipants, updateParticipant logging gaps also closed. ### BUG-8: server adapter has no reconnect -- FIXED — onclose reconnects + re-subscribes existing paths. +- FIXED --- onclose reconnects + re-subscribes existing paths. ### BUG-10: deact+reactivate same round double-acts participant -- FIXED — 1-list model keeps slot position on toggle. Reactivate does not +- FIXED --- 1-list model keeps slot position on toggle. Reactivate does not grant second turn. Test: turn.bug10.test.js. ### BUG-11: FE Combat.scenario test crashes -- FIXED — moved to shared/turn.combat.test.js, pure functions, 100 rounds. +- FIXED --- moved to shared/turn.combat.test.js, pure functions, 100 rounds. ### BUG-12: campaign selection follows activeDisplay - FIXED. ### BUG-13: reorderParticipants crossing current pointer = ambiguous -- FIXED — block cross-pointer reorder during active encounter (both dirs). +- FIXED --- block cross-pointer reorder during active encounter (both dirs). Full fix needs actedThisRound tracking. Pragmatic block prevents skip/double. Pre-combat: free reorder. Test: turn.bug13.test.js. ### BUG-14: addParticipant init-insertion breaks after drag-reorder -- FIXED — slotIndexForInit scans current list (post-drag aware). +- FIXED --- slotIndexForInit scans current list (post-drag aware). ### BUG-15: DisplayView re-sorts (drag order not preserved) -- FIXED — display renders participants[] directly. +- FIXED --- display renders participants[] directly. ### BUG-16: subscribeCollection hook drops queryConstraints -- FIXED — neutral builders, both adapters honor orderBy/limit. +- FIXED --- neutral builders, both adapters honor orderBy/limit. ### BUG-17: dead SDK imports in App.js -- FIXED — trimmed (auth + getFirestore + getStorage remain). +- FIXED --- trimmed (auth + getFirestore + getStorage remain). ### BUG-18: stale comments reference deleted memory adapter - FIXED. ### FEAT-1: Dead participants stay in turn order -- DONE — applyHpChange no longer flips isActive on death. Dead stay in +- DONE --- applyHpChange no longer flips isActive on death. Dead stay in rotation, nextTurn visits them, PCs get death-save turn. ### combat.scenario 100 rounds not turns -- DONE — loops by actual round-wrap count. +- DONE --- loops by actual round-wrap count. ### feat: add all characters to participants list -- DONE — addParticipants bulk add wired. +- DONE --- addParticipants bulk add wired.