fix: custom conditions apply on add; correct server WS env docs
Custom conditions (per-campaign freeform) previously only persisted to the
campaign palette — Add button did NOT apply them to the targeted participant,
and badges rendered via CONDITIONS (missing custom ids) so applied custom
conditions did not display. Now:
- addCustomCondition(label, participantId) persists to palette AND toggles
onto the participant in one step. Enter + Add button both pass p.id.
- Admin badge lookup uses allConditions (built-ins + custom), not CONDITIONS.
Shared contract: toggleCondition accepts ANY string. Prove it in tests:
- turn.combat.test.js adds CUSTOM_CONDITIONS ('hexed','rager',
'marked_for_death','🛡️blessed') to the seeded queue + random pool, asserts
condition-not-string invariant, and a dedicated add/remove round-trip test.
- replay-combat.js mirrors the same CUSTOM_CONDITIONS through the live backend.
Server-mode docs/env: REACT_APP_BACKEND_WS (stale pre-rename) -> correct
REACT_APP_BACKEND_REALTIME_URL=ws://.../ws in README, env.example,
docker/Dockerfile (STORAGE=ws -> server). DEVELOPMENT.md + scripts/README.md
now point to ./scripts/dev-start.sh as the primary dev entrypoint.
133 shared tests green.
This commit is contained in:
+18
-5
@@ -50,14 +50,19 @@ git config core.hooksPath .githooks # enable pre-push test gate
|
||||
|
||||
## Run
|
||||
|
||||
### Backend (dev)
|
||||
### Local dev stack (one command)
|
||||
|
||||
```bash
|
||||
npm run server:dev # :4001, db: server/data/tracker.sqlite
|
||||
# or direct:
|
||||
DB_PATH=./data/tracker.sqlite PORT=4001 node server/index.js
|
||||
./scripts/dev-start.sh # backend :4001 + frontend :3999, server mode
|
||||
./scripts/dev-stop.sh # stop both
|
||||
```
|
||||
|
||||
- backend: `npm run server:dev` (:4001, sqlite `data/tracker.sqlite`)
|
||||
- frontend: `npm start` (:3999, `REACT_APP_STORAGE=server`)
|
||||
- logs: `tmp/server.log`, `tmp/fe.log`
|
||||
|
||||
Idempotent: if port busy, leaves existing proc as-is.
|
||||
|
||||
Smoke check:
|
||||
```bash
|
||||
curl http://127.0.0.1:4001/health # -> {"ok":true}
|
||||
@@ -65,8 +70,16 @@ curl http://127.0.0.1:4001/health # -> {"ok":true}
|
||||
|
||||
Never put db in `/tmp` (wipe risk). Use `./data/` (gitignored) or docker volume.
|
||||
|
||||
### Frontend (dev server, server mode)
|
||||
### Manual (fallback)
|
||||
|
||||
Backend:
|
||||
```bash
|
||||
npm run server:dev # :4001, db: server/data/tracker.sqlite
|
||||
# or direct:
|
||||
DB_PATH=./data/tracker.sqlite PORT=4001 node server/index.js
|
||||
```
|
||||
|
||||
Frontend (server mode):
|
||||
```bash
|
||||
REACT_APP_STORAGE=server \
|
||||
REACT_APP_BACKEND_URL=http://127.0.0.1:4001 \
|
||||
|
||||
Reference in New Issue
Block a user