2 Commits

Include renames

Author	SHA1	Message	Date
david raistrick	c0998da0a7	fix(BUG-4): updateDoc patch on activeDisplay (not setDoc replace) ... All 5 storage.setDoc(activeDisplay, {...}, {merge:true}) → storage.updateDoc(activeDisplay, {...}). setDoc merge:true worked in prod (firebase honors merge) but ws adapter + mock ignore opts arg entirely → clobbers doc. updateDoc uses PATCH across all adapters (firebase real updateDoc, ws PATCH endpoint, mock merge). Consistent, no clobber. Sites fixed: - hidePlayerHp toggle - startEncounter (set active ids) - endEncounter (null active ids) - deactivate active display - activate new display TDD: HideHpToggle.test RED first (assert updateDoc patch, impl still setDoc → 0 calls found). GREEN after switch. Char tests updated: Encounter.characterization (2) + Combat.characterization (2) assert updateDoc on activeDisplay, not setDoc. BUG-4: prod was already fixed (merge:true), test was RED due to mock ignoring opts. Now all 3 adapters consistent via updateDoc.	2026-07-01 23:32:23 -04:00
david raistrick	d979b03f2e	tests: BUG-4 RED locked (hide-HP clobbers activeDisplay), add write recorder ... src/tests/HideHpToggle.test.js: renders App, selects campaign, toggles hide-player-HP switch, asserts setDoc data includes activeCampaignId + activeEncounterId. RED: data only {hidePlayerHp:true}, both clobbered. Root cause proven with evidence (recorder): setDoc(activeDisplay/status, {hidePlayerHp:true}, {merge:true}) data written = {hidePlayerHp:true} ONLY activeCampaignId = undefined activeEncounterId = undefined setDoc = replace per contract. {merge:true} arg ignored. Toggle wipes encounter pointer → DisplayView reads null → 'Game Session Paused'. Fix: use updateDoc (patch), not setDoc. src/storage/firebase.js: adapter recorder now captures setDoc + updateDoc (data + opts). Was subscribe-only. Enables write-path assertions.	2026-06-30 13:55:14 -04:00