3 Commits

Include renames

Author	SHA1	Message	Date
david raistrick	9c90c1500c	feat(turn): D&D 5e death saves — success/fail tracking ... Old model broken: single deathSaves counter, 3=revive. No fails tracked, successes conflated with fails. DM couldn't model real death save outcomes. New model (D&D 5e): - deathSave(enc, id, type, n) — type='success'|'fail', n=1|2|3 - Participant fields: deathSaves (successes), deathFails, isStable, isDying - 3 successes = stable (0hp unconscious, safe until healed) - 3 failures = dead (isDying, caller animates removal) - Toggling same pip = undo that pip - Returns { patch, log, status } — status: 'stable'|'dead'|'pending' isDying back-compat flag kept for App.js removal animation App.js: - UI split into green ✓ saves row + red ✕ fails row - Status badges: Stabilized (emerald) / Dying (red pulse) - handleDeathSaveChange(participantId, type, saveNumber) — new sig - makeParticipant init: deathFails + isStable defaults Data loss: old single-counter participants lose saves (feature didn't work, no real state to preserve). User confirmed acceptable. Tests: - turn.deathsave.test.js: RED-then-GREEN, 3-success stable, 3-fail dead, independent tracking, new signature - Updated 6 callers across characterization/combat/dead-skip/logging/scenario - Logs UI tests: new title selectors (Success N / Fail N) 243 tests green.	2026-07-04 17:56:14 -04:00
david raistrick	79af61cb8b	match main firebase behavior; fix contract + mismatches ... Contract rewritten to match main prod truth: - require id injection in all doc/collection results - honor setDoc({merge:true}) (main L1624 + 4 activeDisplay sites) - drop invented bare<->prefixed cross-lookup tests (main never does this) - add setDoc{merge}, batch set-only/update-only contract coverage Fix mismatches vs main: - subscribeCollection hook now forwards queryConstraints (was dropped; LOG_QUERY sort+limit honored again). Mock onSnapshot honors orderBy+limit. 2 new contract tests prove the chain. - subscribeDoc/subscribeCollection adapters now forward errCb. App hooks + DisplayView propagate subscribe errors to UI (match main onSnapshot 3rd arg). - ws adapter signatures accept queryConstraints + errCb (interface match). activeDisplay writes match main: - 5 unguarded sites -> setDoc({merge:true}) (create-if-missing, not updateDoc) - 3 guarded sites stay updateDoc Delete memory adapter: third storage system added complexity, zero value. firebase-mock covers fast tests, ws covers server path. Factory throws on unknown mode now. Delete phantom 'Phase A/B' comment in firebase.js header. Tests updated to assert setDoc{merge} (not updateDoc) for activeDisplay writes. 83/83 green.	2026-07-04 12:22:19 -04:00
david raistrick	f81308a0df	tests: consolidate into tests/ dirs, fix import paths ... Move all test files out of source dirs into per-workspace tests/: - shared/tests/ (3 unit test files) - server/tests/ (1 integration test) - src/tests/ (8 characterization + scenario tests + testHelpers) Fix all relative import paths (App, storage, __mocks__, testHelpers). Fix jest.config testMatch globs in shared/ and server/ (rootDir + <rootDir>/tests pattern). Delete scripts/repro-pause-bug.js (debug scratch, superseded by turn.pause-add.test.js). Keep scripts/replay-combat.js + scripts/audit-rotation.js as manual demo/exploratory tools (NOT unit tests, not deterministic). No logic changes. All green: shared 49 + 1 validated RED, server 23, FE 62. Scenario test unchanged (240s timeout, pre-existing slow).	2026-06-29 16:02:22 -04:00