2 Commits

Include renames

Author	SHA1	Message	Date
david raistrick	27b2272ced	fix(storage): neutral queryConstraints honored by both adapters ... Bug: server adapter accepted queryConstraints (orderBy/limit) but ignored them. Combat log [orderBy('timestamp','desc'), limit(500)] returned ALL logs unordered in server mode — unbounded growth. No test caught it: shared contract tested subscribeCollection with 0 constraints; the firebase-only queryConstraint test never touched the server adapter. Parity gap. Fix (Plan A — neutral shape): - index.js: orderBy()/limit() now NEUTRAL builders returning {__type}. Removed SDK orderBy/limit re-export. - firebase.js: subscribeCollection translates neutral -> SDK query constraints. - server.js: applyConstraints() helper sorts/limits client-side (backend returns all). Constraints stored per collection, applied on initial fetch + WS change. - contract.js: added 3 queryConstraint tests (orderBy desc, limit, no-constraints) to SHARED contract — both adapters now run identical assertions. - firebase.contract.test.js: removed now-redundant firebase-only constraint block (covered by shared contract). Data impact: ZERO. Constraints are query-time only, never stored. Combat log docs keep timestamp field. No Firebase data migration needed. 208 tests green.	2026-07-04 16:06:28 -04:00
david raistrick	e94e1959ff	refactor: rename ws adapter to server across codebase ... 'ws' conflated storage mode with transport protocol (WebSocket). Renamed for clarity: the adapter talks the self-hosted server (src/storage/server.js), which happens to use WebSocket for realtime — but the name should describe what it connects to, not how. Renames: - src/storage/ws.js -> server.js - createWsStorage() -> createServerStorage() - storage mode 'ws' -> 'server' - REACT_APP_BACKEND_WS -> REACT_APP_BACKEND_REALTIME_URL - factory param wsUrl -> realtimeUrl - server/tests/ws-*.test.js -> server-*.test.js Kept literal: 'ws' npm package, ws:// protocol URLs, /ws WebSocket endpoint. Transport is accurate there; only storage-naming changed. Updated all docs (DEVELOPMENT, TESTING, REWORK_PLAN, GLOSSARY, TODO), scripts (dev-start.sh, replay-combat.js), factory + ESM tests. 204 tests green.	2026-07-04 15:47:13 -04:00