3 Commits

Include renames

Author	SHA1	Message	Date
david raistrick	84a8b78acd	M2: refactor DisplayView to storage adapter (red test first) ... DisplayView missed in original M2 refactor — raw onSnapshot(doc(db,path)) survived. In ws/memory mode db is a stub sentinel, so raw SDK calls crash ('Expected first argument to collection() to be a CollectionReference...'). Reported by human testing player display after start combat. TDD: 1. RED: DisplayView.characterization.test.js asserts adapter.subscribeDoc called for campaign + encounter + activeDisplay paths. Adapter recorder (getAdapterCalls/resetAdapterCalls in firebase.js) instruments subscribe calls — catches raw-SDK bypass that firebase mock alone cannot (mock db satisfies raw onSnapshot, hiding the bug). 2. Fix: 2 raw onSnapshot sites in DisplayView -> storage.subscribeDoc. 3. GREEN: 2 new tests pass, 116 total green. Audit confirmed DisplayView was the ONLY remaining raw SDK site in App.js.	2026-06-29 13:13:46 -04:00
david raistrick	812298fa73	M2: refactor all firebase write sites to storage adapter ... - 37 call sites: setDoc/updateDoc/deleteDoc/addDoc/getDocs/writeBatch -> storage.* - adapter wraps SDK, path-string interface - storage instance app-wide (getStorage) - firebase.js: static imports (getDoc/getDocs alias), no dynamic import 56 frontend tests green. STORAGE=firebase = identical behavior.	2026-06-28 21:05:39 -04:00
david raistrick	12b24eb707	M2 (C): storage barrel re-export, App.js imports swapped ... - src/storage/index.js: re-exports Firebase SDK - App.js: imports from ./storage (was firebase/* direct) - STORAGE=firebase = identical behavior - dev server compiles clean Safe refactor proof. Next: per-call-site path-based rewrite for ws adapter.	2026-06-28 17:51:39 -04:00