ttrpg-initiative-tracker

167 Commits 6 Branches 5 Tags

3 Commits

Include renames

Author	SHA1	Message	Date
david raistrick	e94e1959ff	refactor: rename ws adapter to server across codebase 'ws' conflated storage mode with transport protocol (WebSocket). Renamed for clarity: the adapter talks the self-hosted server (src/storage/server.js), which happens to use WebSocket for realtime — but the name should describe what it connects to, not how. Renames: - src/storage/ws.js -> server.js - createWsStorage() -> createServerStorage() - storage mode 'ws' -> 'server' - REACT_APP_BACKEND_WS -> REACT_APP_BACKEND_REALTIME_URL - factory param wsUrl -> realtimeUrl - server/tests/ws-.test.js -> server-.test.js Kept literal: 'ws' npm package, ws:// protocol URLs, /ws WebSocket endpoint. Transport is accurate there; only storage-naming changed. Updated all docs (DEVELOPMENT, TESTING, REWORK_PLAN, GLOSSARY, TODO), scripts (dev-start.sh, replay-combat.js), factory + ESM tests. 204 tests green.	2026-07-04 15:47:13 -04:00
david raistrick	79af61cb8b	match main firebase behavior; fix contract + mismatches Contract rewritten to match main prod truth: - require id injection in all doc/collection results - honor setDoc({merge:true}) (main L1624 + 4 activeDisplay sites) - drop invented bare<->prefixed cross-lookup tests (main never does this) - add setDoc{merge}, batch set-only/update-only contract coverage Fix mismatches vs main: - subscribeCollection hook now forwards queryConstraints (was dropped; LOG_QUERY sort+limit honored again). Mock onSnapshot honors orderBy+limit. 2 new contract tests prove the chain. - subscribeDoc/subscribeCollection adapters now forward errCb. App hooks + DisplayView propagate subscribe errors to UI (match main onSnapshot 3rd arg). - ws adapter signatures accept queryConstraints + errCb (interface match). activeDisplay writes match main: - 5 unguarded sites -> setDoc({merge:true}) (create-if-missing, not updateDoc) - 3 guarded sites stay updateDoc Delete memory adapter: third storage system added complexity, zero value. firebase-mock covers fast tests, ws covers server path. Factory throws on unknown mode now. Delete phantom 'Phase A/B' comment in firebase.js header. Tests updated to assert setDoc{merge} (not updateDoc) for activeDisplay writes. 83/83 green.	2026-07-04 12:22:19 -04:00
david raistrick	b12ac904a6	test: add storage coverage (firebase contract, factory), silence scenario log - firebase.contract.test.js: run storage contract against createFirebaseStorage via SDK mock. Currently 12 fail (firebase diverges from contract: no norm(), injects id). Failures real — firebase copied from main, memory/ws invented new requirements. Contract under review vs main prod truth. - storage.factory.test.js: getStorage() routing per REACT_APP_STORAGE env, singleton cache, getStorageMode() reporting. - Combat.scenario.test.js: remove console.log (test noise). - package.json: test:all now runs App + shared + server suites (was missing App).	2026-07-03 18:53:58 -04:00

Author

SHA1

Message

Date

david raistrick

e94e1959ff

refactor: rename ws adapter to server across codebase

'ws' conflated storage mode with transport protocol (WebSocket). Renamed for
clarity: the adapter talks the self-hosted server (src/storage/server.js), which
happens to use WebSocket for realtime — but the name should describe what it
connects to, not how.

Renames:
- src/storage/ws.js -> server.js
- createWsStorage() -> createServerStorage()
- storage mode 'ws' -> 'server'
- REACT_APP_BACKEND_WS -> REACT_APP_BACKEND_REALTIME_URL
- factory param wsUrl -> realtimeUrl
- server/tests/ws-*.test.js -> server-*.test.js

Kept literal: 'ws' npm package, ws:// protocol URLs, /ws WebSocket endpoint.
Transport is accurate there; only storage-naming changed.

Updated all docs (DEVELOPMENT, TESTING, REWORK_PLAN, GLOSSARY, TODO), scripts
(dev-start.sh, replay-combat.js), factory + ESM tests. 204 tests green.

2026-07-04 15:47:13 -04:00

david raistrick

79af61cb8b

match main firebase behavior; fix contract + mismatches

Contract rewritten to match main prod truth:
- require id injection in all doc/collection results
- honor setDoc({merge:true}) (main L1624 + 4 activeDisplay sites)
- drop invented bare<->prefixed cross-lookup tests (main never does this)
- add setDoc{merge}, batch set-only/update-only contract coverage

Fix mismatches vs main:
- subscribeCollection hook now forwards queryConstraints (was dropped;
  LOG_QUERY sort+limit honored again). Mock onSnapshot honors orderBy+limit.
  2 new contract tests prove the chain.
- subscribeDoc/subscribeCollection adapters now forward errCb. App hooks +
  DisplayView propagate subscribe errors to UI (match main onSnapshot 3rd arg).
- ws adapter signatures accept queryConstraints + errCb (interface match).

activeDisplay writes match main:
- 5 unguarded sites -> setDoc({merge:true}) (create-if-missing, not updateDoc)
- 3 guarded sites stay updateDoc

Delete memory adapter: third storage system added complexity, zero value.
firebase-mock covers fast tests, ws covers server path. Factory throws on
unknown mode now.

Delete phantom 'Phase A/B' comment in firebase.js header.

Tests updated to assert setDoc{merge} (not updateDoc) for activeDisplay writes.
83/83 green.

2026-07-04 12:22:19 -04:00

david raistrick

b12ac904a6

test: add storage coverage (firebase contract, factory), silence scenario log

- firebase.contract.test.js: run storage contract against createFirebaseStorage
  via SDK mock. Currently 12 fail (firebase diverges from contract: no norm(),
  injects id). Failures real — firebase copied from main, memory/ws invented
  new requirements. Contract under review vs main prod truth.
- storage.factory.test.js: getStorage() routing per REACT_APP_STORAGE env,
  singleton cache, getStorageMode() reporting.
- Combat.scenario.test.js: remove console.log (test noise).
- package.json: test:all now runs App + shared + server suites (was missing App).

2026-07-03 18:53:58 -04:00