Rework backend #1
@@ -25,6 +25,9 @@
|
||||
## Confirmed bugs (tests written, NOT fixed)
|
||||
|
||||
### BUG-1: addParticipant + pause/resume corrupts turn rotation
|
||||
- **RESOLVED** as side effect of BUG-2 fix (dup-id rejection broke chain).
|
||||
- Audit: 0 violations / 100 rounds after BUG-2 fix.
|
||||
- Replay: 10 rounds clean, no skip/dupe.
|
||||
- Audit: 128 violations / 100 rounds, 4 symptom faces.
|
||||
- Symptom chain (one bug family):
|
||||
1. pause blocks nextTurn advance → totalTurns stays frozen (e.g. 120)
|
||||
@@ -43,13 +46,9 @@
|
||||
- Real repro = `node scripts/audit-state.js` (or audit-rotation.js).
|
||||
|
||||
### BUG-2: addParticipant allows duplicate id
|
||||
- `addParticipant(enc, dup)` appends same id to participants[] twice.
|
||||
- togglePause resume rebuilds order → id appears twice in turnOrderIds →
|
||||
nextTurn stuck repeating that id.
|
||||
- Reachable in normal app? App uses crypto.randomUUID (fresh ids) so
|
||||
unlikely. But no guard exists — defensive bug.
|
||||
- **FIXED** (commit: addParticipant throws on dup id).
|
||||
- Test: `shared/tests/turn.characterization.test.js` 'addParticipant rejects
|
||||
duplicate id' — test.skip currently (validates current allow-dup behavior).
|
||||
duplicate id' — GREEN.
|
||||
|
||||
## Pipeline
|
||||
- [ ] Red test: dead participant still in turnOrderIds, turn still advances to them
|
||||
|
||||
@@ -110,7 +110,10 @@ for (let roundN = 1; roundN <= ROUNDS; roundN++) {
|
||||
const np = makeParticipant({ id: `r${totalTurns}`, name:`R${totalTurns}`, type:'monster', initiative:9, maxHp:100, currentHp:100 });
|
||||
try { e = { ...e, ...addParticipant(e, np).patch }; } catch (err) {}
|
||||
}
|
||||
if (totalTurns % 12 === 0) { try { e = { ...e, ...togglePause(e).patch }; } catch (err) {} }
|
||||
if (totalTurns % 12 === 0) {
|
||||
try { e = { ...e, ...togglePause(e).patch }; } catch (err) {}
|
||||
try { e = { ...e, ...togglePause(e).patch }; } catch (err) {}
|
||||
}
|
||||
|
||||
// advance until round wraps or cap
|
||||
const cap = (e.participants.length + 4) * 2;
|
||||
@@ -118,6 +121,7 @@ for (let roundN = 1; roundN <= ROUNDS; roundN++) {
|
||||
const seenThisRound = [];
|
||||
while (e.round === startRound && guard < cap) {
|
||||
if (e.currentTurnParticipantId) seenThisRound.push(e.currentTurnParticipantId);
|
||||
if (e.isPaused) { check('advance-while-paused', false, 'paused at advance'); break; }
|
||||
let t;
|
||||
try { t = nextTurn(e); } catch (err) { check('nextTurn-throws', false, err.message); break; }
|
||||
e = { ...e, ...t.patch };
|
||||
|
||||
Reference in New Issue
Block a user