robert/ttrpg-initiative-tracker
1
0
Fork 0
Code Issues Pull Requests Releases 4 Wiki Activity

Rework backend #1

Merged
robert merged 86 commits from rework-backend into main 2026-07-01 19:29:34 -04:00
Conversation 0 Commits 86 Files Changed 66
+4 -3
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d35a730e12 - Show all commits
shared/tests/turn.characterization.test.js
+1 -3
View File
@@ -338,9 +338,7 @@ describe('addParticipant', () => {
expect(patch.participants.map(x => x.id)).toEqual(['a', 'z']); expect(patch.participants.map(x => x.id)).toEqual(['a', 'z']);
}); });
// SKIPPED: RED test documenting BUG-2 (addParticipant allows dup id). test('rejects duplicate id (skip-bug root cause)', () => {
// See TODO.md BUG-2. Re-enable (remove .skip) when fix lands.
test.skip('rejects duplicate id (skip-bug root cause)', () => {
// Two participants with same id → togglePause resume rebuilds order with // Two participants with same id → togglePause resume rebuilds order with
// dup id twice → nextTurn gets stuck repeating that id forever. // dup id twice → nextTurn gets stuck repeating that id forever.
// Audit found this in 100-round replay (addParticipant fired while paused // Audit found this in 100-round replay (addParticipant fired while paused
shared/turn.js
+3
View File
@@ -270,6 +270,9 @@ function togglePause(encounter) {
// ADD_PARTICIPANT — appends participant. (Initiative rolled by caller via build*.) // ADD_PARTICIPANT — appends participant. (Initiative rolled by caller via build*.)
function addParticipant(encounter, participant) { function addParticipant(encounter, participant) {
if ((encounter.participants || []).some(p => p.id === participant.id)) {
throw new Error(`Participant with id "${participant.id}" already exists in encounter.`);
}
const updatedParticipants = [...(encounter.participants || []), participant]; const updatedParticipants = [...(encounter.participants || []), participant];
return { return {
patch: { participants: updatedParticipants }, patch: { participants: updatedParticipants },