robert/ttrpg-initiative-tracker
1
0
Fork 0
Code Issues Pull Requests Releases 4 Wiki Activity

Rework backend #1

Merged
robert merged 86 commits from rework-backend into main 2026-07-01 19:29:34 -04:00
Conversation 0 Commits 86 Files Changed 66
+5 -3
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e0f75cfb6c - Show all commits
TODO.md
+5 -3
View File
@@ -29,7 +29,9 @@ REWORK_PLAN.md.
### BUG-2: addParticipant allows duplicate id ### BUG-2: addParticipant allows duplicate id
- **FIXED** (commit: addParticipant throws on dup id). - **FIXED** (commit: addParticipant throws on dup id).
- Test: `shared/tests/turn.characterization.test.js` 'addParticipant rejects - Test: `shared/tests/turn.characterization.test.js` 'addParticipant rejects
duplicate id' — GREEN. duplicate id' --- GREEN.
### bug-3 was a halucination has been removed
### BUG-4: hide-player-HP breaks display view (preexisting) ### BUG-4: hide-player-HP breaks display view (preexisting)
- **Broader than hide-HP**: ALL 5 `storage.setDoc(getPath.activeDisplay(), ...)` calls - **Broader than hide-HP**: ALL 5 `storage.setDoc(getPath.activeDisplay(), ...)` calls
@@ -72,7 +74,7 @@ REWORK_PLAN.md.
- nextTurn rotates via `turnOrderIds` only → reorder has NO effect on combat - nextTurn rotates via `turnOrderIds` only → reorder has NO effect on combat
rotation. Mid-encounter drag-drop = pointless. rotation. Mid-encounter drag-drop = pointless.
- replay-combat.js calls reorderParticipants with WRONG signature - replay-combat.js calls reorderParticipants with WRONG signature
`(enc, reorderedArray)` — swallowed by try/catch, silent no-op. So `(enc, reorderedArray)` --- swallowed by try/catch, silent no-op. So
replay never exercised real path either. replay never exercised real path either.
- Fix: reorder must also update turnOrderIds to match new participant order - Fix: reorder must also update turnOrderIds to match new participant order
(within same-initiative tie). (within same-initiative tie).
@@ -88,7 +90,7 @@ REWORK_PLAN.md.
- Display frozen until full reload. - Display frozen until full reload.
- Fix: `onclose` → reconnect + re-subscribe existing paths. - Fix: `onclose` → reconnect + re-subscribe existing paths.
## Pipeline (bugs only — milestones live in REWORK_PLAN.md) ## Pipeline (bugs only --- milestones live in REWORK_PLAN.md)
- [ ] BUG-4: fix setDoc→updateDoc for all 5 activeDisplay sites - [ ] BUG-4: fix setDoc→updateDoc for all 5 activeDisplay sites
- [ ] BUG-5: fix computeTurnOrderAfterAddition currentTurn re-anchor - [ ] BUG-5: fix computeTurnOrderAfterAddition currentTurn re-anchor
- [ ] BUG-6: reorderParticipants update turnOrderIds - [ ] BUG-6: reorderParticipants update turnOrderIds