Rework backend #1

Merged
robert merged 86 commits from rework-backend into main 2026-07-01 19:29:34 -04:00
3 changed files with 75 additions and 0 deletions
Showing only changes of commit e514a48d6e - Show all commits
+11
View File
@@ -96,6 +96,17 @@
- Fix: reorder must also update turnOrderIds to match new participant order
(within same-initiative tie).
### BUG-7: reorderParticipants has no undo
- Test: `shared/tests/turn.undo.test.js` 'reorderParticipants has no undo' (GREEN doc).
- `reorderParticipants` returns `log: null`. Other ops return `log.undo`.
- Cannot undo drag-drop. Candidate for undo system (M6).
### BUG-8: ws adapter has no reconnect
- Test: `server/tests/ws-reconnect.test.js` (RED).
- WS dies (idle/error/close) → `wsReady=null`, subscribers dead forever.
- Display frozen until full reload.
- Fix: `onclose` → reconnect + re-subscribe existing paths.
## Pipeline
- [ ] Red test: dead participant still in turnOrderIds, turn still advances to them
- [ ] Fix `shared/turn.js`: don't drop dead from turn order
+58
View File
@@ -0,0 +1,58 @@
// BUG-8: ws adapter has NO reconnect. WS dies (idle/error/close) → wsReady=null,
// subscribers dead forever, no re-subscribe. Display frozen until full reload.
// Test: subscribe, write (cb fires), force-drop WS, write again (must still fire).
// RED on current.
'use strict';
const path = require('path');
const os = require('os');
const { createServer } = require('../index');
const { createWsStorage } = require('../../src/storage/ws');
const flush = (ms = 150) => new Promise(r => setTimeout(r, ms));
let nextPort = 5000 + Math.floor(Math.random() * 999);
async function makeStorage() {
const port = nextPort++;
const dbPath = path.join(os.tmpdir(), `ws-recon-${port}-${Date.now()}.sqlite`);
const handle = createServer({ dbPath, port });
await new Promise((resolve, reject) => {
handle.server.on('error', reject);
handle.server.listen(port, resolve);
});
const baseUrl = `http://127.0.0.1:${port}`;
const wsUrl = `ws://127.0.0.1:${port}/ws`;
const storage = createWsStorage({ baseUrl, wsUrl });
storage.dispose = (done) => handle.close(done);
return storage;
}
describe('BUG-8: ws adapter reconnect after drop', () => {
test('subscribe fires cb after WS dropped + restored', async () => {
const storage = await makeStorage();
try {
await storage.setDoc('campaigns/a', { name: 'V1' });
const calls = [];
storage.subscribeDoc('campaigns/a', (doc) => calls.push(doc));
await flush();
expect(calls.length).toBeGreaterThanOrEqual(1);
// force-drop WS (simulates idle timeout / network blip)
storage._test.forceDrop();
await flush(300);
// wsReady should be null now
expect(storage._test.getReady()).toBeNull();
// write again — subscriber must re-fire after reconnect
await storage.setDoc('campaigns/a', { name: 'V2' });
await flush(1000);
const last = calls[calls.length - 1];
expect(last).toEqual({ name: 'V2' });
} finally {
await new Promise(r => storage.dispose(r));
}
}, 15000);
});
+6
View File
@@ -160,6 +160,12 @@ function createWsStorage({ baseUrl, wsUrl } = {}) {
dispose() { if (ws) ws.close(); docSubs.clear(); collSubs.clear(); },
_api: api,
_test: {
getWs: () => ws,
forceDrop: () => { if (ws) ws.close(); },
getReady: () => wsReady,
docSubs, collSubs,
},
};
return storage;