robertandClaude Fable 5
995347d255
The logs page white-screened when deployed against Firestore. LogsView
paginates with the neutral offset() constraint, which the server/sqlite
adapter pushes into SQL — but the firebase adapter's subscribeCollection
had no case for it and passed the raw {__type:'offset'} object through
to the SDK's query(), which throws on non-QueryConstraint values. The
throw fired inside useFirestoreCollection's effect on first render,
unmounting the whole tree. Dev never hit it because dev runs the server
adapter.
Fix: shared toSdkConstraints() translator in the firebase adapter,
used by getCollection and subscribeCollection. The client SDK has no
offset, so emulate it — widen limit to offset+limit and slice the
leading docs off the snapshot (same read cost as the admin SDK's
native offset, which also bills skipped docs). Unknown constraint
types are now dropped instead of passed through, so a future neutral
builder can't reintroduce the crash. This also fixes getCollection
silently skipping offset, which returned page 1 for every page.
Server/sqlite adapter unchanged; offset still runs in SQL. Two new
shared contract tests (offset pagination + offset past end) run
against both adapters and pass: firebase mock 33, live sqlite 40.
Also bump better-sqlite3 ^11.3.0 -> ^12.0.0: v11 fails to compile
against Node 26's V8 (GetPrototype removed), so server tests could
not run at all on Node 26. v12.11.1 builds clean; full server suite
passes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
25 lines
589 B
JSON
25 lines
589 B
JSON
{
|
|
"name": "@ttrpg/server",
|
|
"version": "0.1.0",
|
|
"private": true,
|
|
"description": "Self-hosted backend: Express + ws + better-sqlite3. Server-authoritative turn logic.",
|
|
"main": "index.js",
|
|
"scripts": {
|
|
"dev": "node --watch index.js",
|
|
"start": "node index.js",
|
|
"test": "../scripts/cap.sh 30 jest --forceExit"
|
|
},
|
|
"dependencies": {
|
|
"@ttrpg/shared": "*",
|
|
"better-sqlite3": "^12.0.0",
|
|
"cors": "^2.8.5",
|
|
"express": "^4.19.2",
|
|
"nanoid": "^5.0.7",
|
|
"ws": "^8.18.0"
|
|
},
|
|
"devDependencies": {
|
|
"jest": "^29.7.0",
|
|
"supertest": "^7.0.0"
|
|
}
|
|
}
|