Files
ttrpg-initiative-tracker/scripts/combat.js
T
david raistrick 2569cc4497 Builds replayable combat logs with first-class undo/redo, unified verification tooling, fast indexed log queries, and stricter CI.
feat(combat): add first-class undo and redo controls

Add undo and redo controls to the combat UI so the DM can recover from recent
actions without leaving the encounter view.

Undo and redo operate on the current encounter's combat history. Empty stacks
produce clear feedback instead of failing silently. Redo order follows normal
stack behavior after multiple undos.

This makes combat history actionable during play, not just visible in the log.

feat(logs): make combat logs replayable

Replace plain combat log messages with structured combat events that can be
used by the UI, exported as JSON, replayed, and verified.

Each new log entry records the action type, encounter identity, participant
identity, a small action delta, undo intent, and a turn snapshot. Download and
copy now export the event stream as JSON so a saved combat log is useful for
offline analysis and debugging.

Legacy logs remain viewable, but new logs use the structured event format.

feat(logs): make undo and redo transactional

Apply undo and redo as single storage operations so the encounter state and log
state cannot drift apart.

Server storage applies the encounter update and the log undone flag inside one
SQLite transaction. Firebase storage uses a batch write for the same behavior.
The storage contract now includes undo/redo semantics.

This replaces fragile multi-write undo behavior where a failure could update
the encounter without marking the log, or mark the log without updating the
encounter.

feat(combat): add unified replay and verification tool

Add one combat CLI for replaying live combat and verifying combat logs.

Replay drives the live backend through the same shared combat logic used by the
app, writes a JSON event log to an explicit output path, and automatically
verifies the result. Verification checks for DM-visible combat problems such as
skipped turns, double actions, bad round changes, and unexpected turn order
changes.

The tool uses the same JSON event stream produced by log downloads, supports
verbose turn output, and handles Ctrl-C by ending the encounter, writing the
partial log, and verifying what was captured.

fix(perf): keep long combat logging fast

Remove the combat-time log query bottleneck that made long replays slow as log
volume grew.

Combat controls no longer subscribe to the log collection just to keep undo and
redo state warm. Undo and redo now query the latest matching encounter log only
when clicked. Server collection queries support exact filters, ordering,
limits, and offsets, and SQLite indexes keep latest-log and per-encounter log
lookups fast.

Also fix duplicate WebSocket handler registration so realtime updates do not
double-fire under write load.

fix(turns): make toggle active a status change

Make toggle active a roster/status edit instead of a turn advance.

Deactivating the current participant no longer passes the turn or increments
the round. The current turn stays where it is until the DM explicitly clicks
Next Turn, and Next Turn skips inactive participants during normal rotation.

This matches the initiative design: slot order is stable, toggle active does
not move participants, and round changes only come from explicit turn advance.

chore(ci): make warnings and hangs fail fast

Tighten test and build checks so failures are visible instead of noisy or
silent.

Builds run with CI enabled so warnings fail production builds. The full test
command runs app, shared, and server suites with hard timeouts so hangs fail
quickly. Static eslint coverage fails on warnings as well as errors.

Tests were updated around the new async combat logging flow, structured log
events, transactional undo, replay verification, and toggle-active semantics.
2026-07-06 10:33:28 -04:00

134 lines
4.7 KiB
JavaScript

#!/usr/bin/env node
// scripts/combat.js
// ONE tool. Replaces replay-combat.js + analyze-turns.js + replay-from-logs.js.
//
// Two modes (same binary):
//
// combat replay — drive a fresh combat through LIVE backend, write log
// combat verify — read any log file, check combat rotated correctly
//
// WHY ONE TOOL:
// Same data, same words. Old 3-tool split = format + naming nightmare.
// Replay writes the log, verify reads it. Same log shape both ends.
//
// LOG FORMAT:
// JSON array. Same as app download. One mental model. NOT jsonl.
// Each entry = canonical lean event (shared/logEvent.js shape):
// { id, ts, type, message, encounterId, encounterName, encounterPath,
// participantId, participantName, delta, undo, undone, snapshot }
// snapshot = { round, currentTurnParticipantId, turnOrderIds, activeIds }
//
// USAGE:
// combat replay [rounds] [delayMs] --out <log.json> [-v]
// combat verify <log.json>
// cat events.json | combat verify
//
// EXIT:
// replay: 0 success, 1 error, 2 bad args
// verify: 0 all checks pass, 1 bugs found, 2 bad args/no input
//
// WHAT VERIFY CHECKS (in DM words, not internals):
// - Round count go up correctly (no skip, no jump, no backward)
// - Turn pass to right person each step
// - Nobody act twice in same round
// - Nobody get skipped who was active whole round
// - Turn order stay stable (no random reshuffle)
// - Initiative slot order hold (replay logs only — need full roster)
'use strict';
const crypto = require('crypto');
const fs = require('fs');
const path = require('path');
const shared = require('../shared');
const { normalizeEvent, serializeEvents } = shared.logEvent;
// =============================================================================
// ARGS
// =============================================================================
function parseArgs(argv) {
const mode = argv[0];
const rest = argv.slice(1);
if (mode !== 'replay' && mode !== 'verify') return { mode: null };
const out = { mode, verbose: false, out: null, positional: [] };
for (let i = 0; i < rest.length; i++) {
const a = rest[i];
if (a === '-v' || a === '--verbose') { out.verbose = true; continue; }
if (a === '--out' && rest[i + 1]) { out.out = rest[i + 1]; i++; continue; }
out.positional.push(a);
}
return out;
}
function usageReplay() {
console.error('Usage: combat replay [rounds] [delayMs] --out <log.json> [-v]');
console.error(' --out <log.json> REQUIRED. Path you control.');
console.error(' rounds default 20, delayMs default 200');
console.error(' -v / --verbose log every action per turn');
process.exit(2);
}
function usageVerify() {
console.error('Usage: combat verify <log.json>');
console.error(' cat events.json | combat verify');
process.exit(2);
}
const args = parseArgs(process.argv.slice(2));
if (!args.mode) {
console.error('combat — unified replay + verify for the TTRPG combat tracker');
console.error('');
console.error('Usage:');
console.error(' combat replay [rounds] [delayMs] --out <log.json> [-v]');
console.error(' combat verify <log.json>');
console.error(' cat events.json | combat verify');
process.exit(2);
}
// =============================================================================
// REPLAY MODE
// =============================================================================
// Drive fresh combat through live backend. Each mutation = one lean log entry
// written to --out path. DM-facing stdout: round headers + per-turn actions.
// Same log shape as app download. verify reads it back.
if (args.mode === 'replay') {
if (!args.out) usageReplay();
require('./combat/replay.js')(args).catch(err => {
console.error('replay failed:', err);
process.exit(1);
});
}
// =============================================================================
// VERIFY MODE
// =============================================================================
// Read a combat log (app download OR combat replay output). Check rotation
// correctness. DM-facing output: combat name, rounds, per-round turn list,
// checks pass/fail. No "mutation", "pointer", "invariant" in output.
if (args.mode === 'verify') {
const logPath = args.positional[0];
let text;
if (logPath) {
if (!fs.existsSync(logPath)) {
console.error(`combat verify: file not found: ${logPath}`);
process.exit(2);
}
text = fs.readFileSync(logPath, 'utf8');
} else if (!process.stdin.isTTY) {
text = fs.readFileSync(0, 'utf8');
}
if (!text || !text.trim()) usageVerify();
try {
const result = require('./combat/verify.js')(text, { verbose: args.verbose });
process.exit(result);
} catch (err) {
console.error('verify failed:', err);
process.exit(1);
}
}