david raistrick
ebd91ca42a
Participant card fields now editable in place (D-style): transparent bg,
underline on hover/focus, no spinners. Covers Initiative, Current HP, Max HP,
and AC badge value.
Click any value to edit. Blur/Enter saves. Escape cancels. Status recomputes
on HP change (conscious/dying/dead/down per ruleset).
Editing overlay: when a field is focused, amber ring highlights the card and
a centered pointer-events-none label shows '✎ Editing {field}'. Label floats
over card middle without blocking input — taps pass through to field.
Handlers: handleInlineCurrentHp (recomputes status), handleInlineMaxHp,
handleInlineAc. Keys prefixed to avoid React key collisions when values match.
Tests: selectors updated to use element id (monsterMaxHp) since inline
aria-labels now match form label queries.
3.6 KiB
3.6 KiB
TODO
Backlog of bugs + long-term items. Milestones live in REWORK_PLAN.md.
Open
x fullscreen and dont lock on main app dm view and the no-game-player view ...and doesnt actually prevent lock on android
also better vert tab layout - labelt friendly
x needs AC for players dude
x and quick entry hp
hp do not carry from encounter to ecnounter!!! ^feature to add back to campaign character after encounter? maybe campaign toggle in charc section (choosing each end is DM overload will be missed forgotten done wront)
hp wont go over max and no temp hp support
refresh/reload/code update causes UI to update to top unselected cambpaign have to drill all the way back down to active encounter....every time. siemtmes?
dm list - keep active particpant in view (scroll)
not sure good way to do this
npm install warnings cleanup pass
lots of updates
monsters per campaign and npcs
or/and ....copy from encoubnter?
TEST GAP: current branch changes need focused coverage
- Storage
where()contract: firebase + server adapters should honor[where('encounterPath','==',x), orderBy('ts','desc'), limit(n)]. - Server SQL query test:
where + orderBy + limitshould return latest logs for one encounter only. - Undo/redo stack order: undo A3 then A2, redo must replay A2 first, then A3.
- Combat controls should not subscribe to logs while mounted; undo/redo should query logs only on click.
- Unified CLI smoke:
node scripts/combat.js verify <fixture.json>returns CLEAN on known-good log. - Unified CLI replay smoke:
node scripts/combat.js replay ... --out tmp/x.jsonwrites JSON array and auto-verifies. - Ctrl-C replay behavior: SIGINT during replay should end encounter, clear active display, write partial log, run verify.
- SQLite schema/index test:
idx_docs_parent_tsandidx_docs_parent_encounter_tsexist for server DB.
confirm warnings treated as error = fail in all tests, build pipeline, linters, everything. again.
BUG: addParticipants (batch add) does not slot by initiative
- shared/turn.js addParticipants appends
[...existing, ...new], no slotIndexForInit. - Violates INIT doc: "Add = insert into slot by initiative."
- Single addParticipant slots correct. Batch (add-all-chars) appends.
- Pre-start batch add = wrong order. Post-start worse.
BUG: nextTurn throws on solo combatant
- nextActiveAfter loop
for step=1; step<nskips when n=1 → {nextId:null}. - nextTurn throws "Could not determine next participant."
- Solo active combat cannot pass turn.
BUG: reorderParticipants cross-pointer drag = silent no-op
- Cross-pointer drag returns encounter unchanged, no log, no toast.
- DM drags across current turn → nothing happens, no feedback.
BUG: addParticipant undo missing currentTurnParticipantId when started
- undo saves participants + conditional turnOrderIds, no currentTurnParticipantId.
- Pointer can misalign on undo if added near pointer region.
BUG: computeTurnOrderAfterRemoval isActive uses find() not boolean
isActive = id => updatedParticipants.find(p => p.id === id && p.isActive)- Returns participant obj (truthy) not boolean. Works by accident, fragile.
FEAT: clarify "Is NPC" in add-participant
- Ambiguous label. May expand work based on what NPC means here (ally? monster? display-only? skip in turn order?). Clarify intent before UX changes.