david raistrick
bac94d85ff
turn.reorder.test.js: 4 green (swaps, throws-diff-init, throws-missing-id, documents current no-turnOrderIds-touch) + 1 RED (BUG-6: should update turnOrderIds to reflect new order). Found: reorderParticipants changes participants[] array but not turnOrderIds. nextTurn rotates via turnOrderIds only → mid-combat drag-drop = no effect. replay-combat.js calls with wrong signature (swallowed by try/catch), so real path never exercised either. TODO: BUG-6 added.
67 lines
2.4 KiB
JavaScript
67 lines
2.4 KiB
JavaScript
// Characterization for reorderParticipants correct usage.
|
|
// replay-combat.js calls it with wrong signature (swallowed by try/catch),
|
|
// so real behavior untested. Lock what it actually does.
|
|
|
|
const shared = require('@ttrpg/shared');
|
|
const { makeParticipant, startEncounter, nextTurn, reorderParticipants } = shared;
|
|
|
|
function p(id, init, extra = {}) {
|
|
return makeParticipant({
|
|
id, name: id, type: 'monster',
|
|
initiative: init, maxHp: 100, currentHp: 100,
|
|
...extra,
|
|
});
|
|
}
|
|
function enc(ps) {
|
|
return { name:'t', participants:ps, isStarted:false, isPaused:false,
|
|
round:0, currentTurnParticipantId:null, turnOrderIds:[] };
|
|
}
|
|
|
|
describe('reorderParticipants', () => {
|
|
test('swaps two same-initiative participants', () => {
|
|
const ps = [p('a', 10), p('b', 20), p('c', 20)]; // b,c tie
|
|
let e = enc(ps);
|
|
e = { ...e, ...startEncounter(e).patch };
|
|
// initial order: b,c,a (init 20,20,10)
|
|
expect(e.turnOrderIds).toEqual(['b', 'c', 'a']);
|
|
const r = reorderParticipants(e, 'c', 'b');
|
|
expect(r.patch.participants.map(p => p.id)).toEqual(['a', 'c', 'b']);
|
|
});
|
|
|
|
test('throws if initiatives differ', () => {
|
|
const ps = [p('a', 10), p('b', 20)];
|
|
let e = enc(ps);
|
|
e = { ...e, ...startEncounter(e).patch };
|
|
expect(() => reorderParticipants(e, 'a', 'b')).toThrow();
|
|
});
|
|
|
|
test('throws if id not found', () => {
|
|
const ps = [p('a', 10), p('b', 20)];
|
|
let e = enc(ps);
|
|
e = { ...e, ...startEncounter(e).patch };
|
|
expect(() => reorderParticipants(e, 'a', 'zzz')).toThrow();
|
|
});
|
|
|
|
test('does NOT touch turnOrderIds (only reorders participants array)', () => {
|
|
// Documents current behavior. If reorder is meant to affect combat
|
|
// rotation mid-encounter, this is BUG-6.
|
|
const ps = [p('a', 10), p('b', 20), p('c', 20)];
|
|
let e = enc(ps);
|
|
e = { ...e, ...startEncounter(e).patch };
|
|
const r = reorderParticipants(e, 'c', 'b');
|
|
expect(r.patch.turnOrderIds).toBeUndefined();
|
|
});
|
|
|
|
// BUG-6 candidate: reorder should affect turnOrderIds so mid-combat
|
|
// drag-drop changes who goes next within same-initiative tie.
|
|
// Currently RED (turnOrderIds not in patch).
|
|
test('reorder updates turnOrderIds to reflect new participant order', () => {
|
|
const ps = [p('a', 10), p('b', 20), p('c', 20)];
|
|
let e = enc(ps);
|
|
e = { ...e, ...startEncounter(e).patch };
|
|
// order: b,c,a
|
|
e = { ...e, ...reorderParticipants(e, 'c', 'b').patch };
|
|
expect(e.turnOrderIds).toEqual(['c', 'b', 'a']);
|
|
});
|
|
});
|